RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support

["Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>]

Jan, 
        Here is the updated one, I add the BUILD_BUG_ON() and some comments. 
Also CC Dan. Thanks!

Best Regards, 
-- Dongxiao

Jan Beulich wrote:
>>>> "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> 11.12.09 14:10 >>>
>>      Thanks for reminder. I ever noticed this problem, but I forgot to
>> modify the code in that version. Attached is the updated one.
> 
> Sorry, but I don't think this is any better. Sill no build-time
> checking, and still the potential for getting completely out of sync
> what is already very fragile (the VMX_INDEX_MSR_* enumeration and the
> msr_index array): 
> Just to repeat, what if somebody adds another enumerator (naturally)
> at the end (i.e. after VMX_INDEX_MSR_TSC_AUX), and the
> corresponding MSR index at the end of msr_index[]?
> 
> Jan

Attachment: 02-add-hvm-rdtscp-support.patch
Description: 02-add-hvm-rdtscp-support.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel