Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 01/12/2009 23:04, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> What's the bug?  I don't see a reentrancy issue there because the
> suspend happens synchronously in the xenwatch thread under
> xenwatch_mutex.  Or race for that matter.
> 
> Am I missing something?
> 
> 
> Of course, if you start triggering suspends via event channels, we'll
> need to work out something else.

The issue in 2.6.18 was that, if doing back-to-back save/restores, the next
event-channel notification could come in before domU was finished with
previous s/r cycle, and then the notification got dropped. There are a
number of ways of dealing with that of course: I implemented a little state
machine; or you could probably do it with some kind of ticket-based scheme;
or perhaps have the evtchn irq handler spawn a kthread which blocks on the
mutex (I liked that one least as it needs to allocate resources).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel