Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool

[Brendan Cully <brendan@xxxxxxxxx>]

On Tuesday, 01 December 2009 at 15:04, Jeremy Fitzhardinge wrote:
> On 12/01/09 08:16, Brendan Cully wrote:
> > I'll probably take a crack at this soon. From a quick look at the
> > pvops suspend code, it seems like it may suffer from a race when
> > multiple suspends are issued that Keir fixed in the 2.6.18 tree some
> > time ago -- it'd be better to get that fixed before porting the event
> > channel patch.
> >   
> 
> What's the bug?  I don't see a reentrancy issue there because the
> suspend happens synchronously in the xenwatch thread under
> xenwatch_mutex.  Or race for that matter.
> 
> Am I missing something?

I'll need to take a closer look, but the race I'm remembering was fixed
in the 2.6.18 tree here:

http://xenbits.xen.org/linux-2.6.18-xen.hg/rev/49ffe9ef67d4

> Of course, if you start triggering suspends via event channels, we'll
> need to work out something else.

yep.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel