[Xen-devel] [PATCH] (resend) Use vnc-listen setting specified in xend config file

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

My mailer botched original patch as it exceeded 80 columns - apologies.

If domU frame buffer configuration has no vnclisten attribute set, use
the global vnc-listen address specified in xend configuration file when
updating vfb location.  Currently the hardcoded value 'localhost' is used.

Example: User specifies (vnc-listen '192.168.0.1') in xend configuration
file and does not have vnclisten set in domU configuration.  Starting a
domU with this configuration results in vfb location containing

            (location localhost:5900)

instead of

            (location 192.168.0.1:5900)


    Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>


diff -r 0e1449d6f231 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Fri Mar 13 10:09:25 2009 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py   Mon Mar 16 13:17:03 2009 -0600
@@ -1410,7 +1410,8 @@ class XendDomainInfo:
             for dev_uuid, (dev_type, dev_info) in self.info['devices'].items():
                 if dev_type == 'vfb':
                     old_location = dev_info.get('location')
-                    listen_host = dev_info.get('vnclisten', 'localhost')
+                    listen_host = dev_info.get('vnclisten', \
+                                XendOptions.instance().get_vnclisten_address())
                     new_location = '%s:%s' % (listen_host, str(vnc_port))
                     if old_location == new_location:
                         break

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel