Re: [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly with CFLAGS_tmp

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 12/01/2009 18:55, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> However this seddery is not actually necessary because there is plenty
>> of other machinery for (a) only setting -fomit-frame-frame-pointer
>> when applicable AND (b) passing -fno-omit-frame-pointer later on the
>> command line if it's not applicable.  So we already have belt and
>> braces and can remove the safety pins.
> 
> You missed a := in arch/x86/Rules.mk. Can that one be avoided so easily?

Ah, well the answer is rather obviously yes. I'll fix this one up myself and
check it in.

I'll also adjust cc-option to run $(CC) immediately and add the resulting
appropriate option correctly even to a recursively-expanded variable. So
$(CC) execution is not delayed and does not occur multiple times even if
CFLAGS is expanded multiple times.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel