Re: [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly with CFLAGS_tmp

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 12/01/2009 17:05, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> It is usually better to use `=' in Makefiles than `:='.  The expansion
> rules for `:=' are simpler - so simple in fact that they don't work if
> any part of the expansion depends on the source or target filenames.
> 
> In this patch we remove the shuffling of the value of CFLAGS between
> := and = flavour variables.  This was previously `necessary' because
> otherwise it would run the seddery for removing -fomit-frame-pointer
> once for each rule.
> 
> However this seddery is not actually necessary because there is plenty
> of other machinery for (a) only setting -fomit-frame-frame-pointer
> when applicable AND (b) passing -fno-omit-frame-pointer later on the
> command line if it's not applicable.  So we already have belt and
> braces and can remove the safety pins.

You missed a := in arch/x86/Rules.mk. Can that one be avoided so easily?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel