Re: [PATCH] Re: [Xen-devel] [PATCH] Std VGA Performance

["Robert Phillips" <rsphillips@xxxxxxxxx>]

Alex is correct;  there is a bug with size=32 operations. 
The fix is simple.  We'll submit an updated patch very soon.
-- rsp

On 10/30/07, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx > wrote:

On 30/10/07 16:40, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

> On Tue, 2007-10-30 at 16:24 +0000, Keir Fraser wrote:
>> Yeah, hopefully that's a bug in the comment. I would expect 4-byte accesses
>> to be possible and be handled. As for 8-byte accesses, they can certainly
>> happen, why not? Unlikely at start of day, but once we're in x86/64 mode
>> there's no reason why not.
>
>    Right, and it seems that the "quadword" handling is quite specific to
> timeoffset.  It takes advantage of the fact that that there's no address
> and stuff some of the data in there.  So, I think both 4 & 8 byte
> buffered mmio is likely broken right now on x86.  Thanks,

I guess we'll see how testing goes over the next little while. If the
bufioreq changes prove to be broken we can back them out before 3.2.0 , or
better yet fix them ;-).

-- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel