Re: [Xen-devel] [PATCH] Fix stdvga performance for 32bit ops

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 1/11/07 16:33, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>>         Corrected a bug in the stdvga code where it did not
>>         properly handle 32 bit operations.
>>         The buf_ioreq_t can now store 32 bits of data.
>>         Because this increases its size to 8 bytes,
>>         only 510 elements fit in the buffered_iopage
>>         (down from 672 elements).
> 
>    Aren't we relying on some compiler dependent packing to get this to 8
> bytes?  I think it'd be best if we were more explicit in the definition.
> Thanks,

If gcc gets it right, that's good enough. We always build Xen and ioemu with
gcc.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel