RE: [Xen-devel] [PATCH][XEN]xm dump command add on

[Ken Hironaka <hironaka.ken@xxxxxxxxxxxxxxxx>]

Simon,

Comments are enclosed.
On Wed, 2006-08-16 at 22:47 -0400, Graham, Simon wrote:
> > > 1. in xc_domain_dumpcore_via_callback why not just 'goto error_out;'
> > if
> > > sts<0? (as is done
> > >    if the callback returns an error)
> > >
> > just because dumping failed on one page, it doesn't mean that the
> whole
> > dump is useless. in fact, there are many cases where the debugger
> would
> > like to see even a little information to help him/her. so i think it
> is
> > better to keep on dumping even if an error has occured. especially
> with
> > live dump, the page table state can change even while dumping, and if
> > that is the case, the dump can fail to dump a page even if it is not
> > caused by a critical error. instead, a message that shows how many
> > pages
> > failed as been logged.

Ok, I will release a new patch that fill failed dump pages with 0s.

best regards,
Ken


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel