RE: [Xen-devel] [PATCH][XEN]xm dump command add on

["Graham, Simon" <Simon.Graham@xxxxxxxxxxx>]

> > 1. in xc_domain_dumpcore_via_callback why not just 'goto error_out;'
> if
> > sts<0? (as is done
> >    if the callback returns an error)
> >
> just because dumping failed on one page, it doesn't mean that the
whole
> dump is useless. in fact, there are many cases where the debugger
would
> like to see even a little information to help him/her. so i think it
is
> better to keep on dumping even if an error has occured. especially
with
> live dump, the page table state can change even while dumping, and if
> that is the case, the dump can fail to dump a page even if it is not
> caused by a critical error. instead, a message that shows how many
> pages
> failed as been logged.
> 

OK - makes sense - might want to zero out the buffer in this case (or
fill it with CC's or somesuch) to avoid misinterpreting the data.

> > 3. As others have commented, you really should log this command to
> > xend.log with log.info()
> >    (especially if you leave in the -L and -C options!) and the log
> > should include info on
> >    whether or not a pause/crash was done - this is very important
> when
> > you go back to try
> >    and work out why a domain paused or stopped unexpectedly!
> 
> i am not sure if i am misundertanding your comment, but they are
logged
> into Xend.log. since they are combined with xm pause/unpause and
> destory, they are also logged as well by default.

OK - just wanted to make sure the results were output to the log as well
as to the person who issues the command...

Simon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel