RE: [Xen-API] Patch discussion: Add NTP field to PIF to ntp configure

[Rob Hoes <Rob.Hoes@xxxxxxxxxx>]

Hi Alberto,

Sorry for the late reply!

The patch looks good to me as well, and could indeed be quite useful. I'd just 
like to ask Simon Rowe (cc'ed) to review the part where ntp.conf is changed, as 
I am not too familiar with that.

Simon, could you take a look at Alberto's email below and the changes to 
interface-reconfigure, which are at the end of the patch (I have re-attached 
it)?

Thanks,
Rob

> -----Original Message-----
> From: Jonathan Ludlam
> Sent: 01 October 2010 21:54
> To: Alberto González Rodríguez; Rob Hoes
> Cc: xen-api@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-API] Patch discussion: Add NTP field to PIF to ntp
> configure
> 
> Hi Alberto,
> 
> Looks good to me! I'd like to get Rob Hoes to have a look over it as he
> knows the networking bits of xapi better than anyone.
> 
> Rob, what do you think?
> 
> Jon
> 
> 
> 
> -----Original Message-----
> From: xen-api-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-api-
> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Alberto González Rodríguez
> Sent: 01 October 2010 09:47
> To: xen-api@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-API] Patch discussion: Add NTP field to PIF to ntp
> configure
> 
> This is a simple patch, but i think could be very useful.
> 
> Until now you only can configure ntp on installation or editing manully
> ntp.conf file.
> 
> Idea is has a field called NTP on PIF class, and when interface-
> reconfigure is called add this servers to ntp.conf and reload ntpd
> service.
> 
> I attach the patch, example to test it:
> 
> 
> xe pif-reconfigure-ip uuid=eb6e90c5-55f2-58b2-0748-0b8ff1963587
> NTP=es.pool.ntp.org,ru.pool.ntp.org mode=static IP=10.110.1.37
> gateway=10.110.1.1 DNS=193.146.32.86 netmask=255.255.255.0
> 
> Now you can see on /etc/ntp.conf on bottom:
> server es.pool.ntp.org
> server ru.pool.ntp.org
> 
> and  " ntpq -c peers" shows the new values:
> 
> *ntp01.srv.cat   150.214.94.5     2 u    -   64  377   26.617  -85.780
> 1.165
> +81.95.131.130   129.69.1.153     2 u   12   64  257   88.981  -84.231
> 1.933
> 
> And you can see
> 
> #xe pif-param-list uuid=eb6e90c5-55f2-58b2-0748-0b8ff1963587|grep NTP
>                         NTP ( RO): es.pool.ntp.org,ru.pool.ntp.org
> 
> NTP is not a required parameter to reconfigure a PIF.

Attachment: ntp.patch
Description: ntp.patch

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api