[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Fix the display of GnttabDebugCallback Address
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 28 Apr 2026 12:46:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+d/kDsvUKdBV6YJsltCsUdhMY2dR1RywxHL+OObr/Yo=; b=Ot1zrUzYgsqw8P2RWDmxIHD7XMhd9G+2R52WuBDvrv0JaRZytFIzLZ+ZLpjogqEgAQKJNagrBduhcv3wSbJ+waUbpo6vCiTa6usFSkwYcgfMsurAIBraockvGztqmjZ19rlhouuxhu3S4xs6CZlwE+DRbuwzMEXIB3YMPSIt2UV/chNcOKNFFb6feZh79dIVOKjqeMlPJFSPcsMBO6GMavmgPurb02lE19Zi/QJr4KgdmsIuT+xU855hRNTzzJMcd35IWAKPtEC4ylxV7DUxIiiCMsv0/vQq5hwNo6Pi1eJKrQpOKEY0C/QHneAvxZkNljNjsLuYdLvopOT/GYax0w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gJxKuu2Aw3Om6HhwEGaIN6TdwG/RFKuCnwCePSneB2SP7Vl41dLsH8qtrV7cCgNIiXEhFz8kY08Oh6geOVKgxXkywEoQIxGdKomsht9USG4bR5XI1hIfXdVzQMkn2rEcAZZWS5mWZWz94U+E9Pgsu53XRBw0+Su9ZCSPQ/AUBaSGl1e13703xaAaFFJSbOn1IA2k5hDtQJpBEaRutvBSiJNfkfiCYQxBMIKIMF54A25TYlHafkNEyuiV8MaJKtmzAMDUgqLJ1+x39qFLwnIUXVE70aB86Ee2ZjpVIbn85y+Fjr1FKjbqeZymUjaVK2pO2aEgjeussSgj/nquwv2ExA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Tue, 28 Apr 2026 12:46:09 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHc1ueI3XcyNnEkFkOMQnioWaYprbX0bCCL
- Thread-topic: [PATCH 2/2] Fix the display of GnttabDebugCallback Address
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>
________________________________________
From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 28 April 2026 9:17 AM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Tu Dinh; Owen Smith
Subject: [PATCH 2/2] Fix the display of GnttabDebugCallback Address
PFN_NUMBER is an ULONG and needs to be upcasted first.
Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
src/xenbus/gnttab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xenbus/gnttab.c b/src/xenbus/gnttab.c
index ea95edf..71f8ec1 100644
--- a/src/xenbus/gnttab.c
+++ b/src/xenbus/gnttab.c
@@ -816,7 +816,7 @@ GnttabDebugCallback(
PXENBUS_GNTTAB_FRAME Frame = &Context->Frame[Index];
PHYSICAL_ADDRESS Address;
- Address.QuadPart = MmGetMdlPfnArray(Frame->Mdl)[0] << PAGE_SHIFT;
+ Address.QuadPart = (LONGLONG)MmGetMdlPfnArray(Frame->Mdl)[0] <<
PAGE_SHIFT;
XENBUS_DEBUG(Printf,
&Context->DebugInterface,
--
2.53.0.windows.2
--
Ngoc Tu Dinh | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
