[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Remove ASSERT on CacheGet object allocation failure
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 28 Apr 2026 12:45:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=turBy+HEo71OwAYiZ3pN6I8vYaCOmebbkNTvSTnRMwU=; b=Mxl5dRbdoAkV4UZsxZT0owr48I2wLB9WKoU4IozWHnFUeZHeGs/Ai2WyYKyWN4JpfTNP9KfT4Jb67HOi5unEYOndRqbXRtuhN3yVUirJNUqItq0+5QWf1+EtZTECr6MwkLtrnQbl29ePuxJ6fuMjHIZEWv6oaYHAEfxSnB1XsUJ2Ak34r8aGUZnSiBYvzms3vw04zJEAWC0WlGXlTqpxKmUOHz5a1vYETvRvq9ZhpVNElMoji8iCMfbVmBN04ovs24QRnmHx/vQEyOHDsO4fs+d5TgHDzphKuUH1TfGXqirWn2jaFppn74nU1Ap81xDZ+AtGaTGLXGbG5AIbxCg/Ag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KkIpWJG9731Pf+wrOVt8AnILtSwE3hlqGdru4S+3g1lx4M+vPcRSrIb91mkR9xoFrhFfe6moZkUe/riBm7dkp6nI/0nLXsBcE3cS3UKEkq4a55oOCoTgQ35eJi7sH7ER1klYxjOV2BV9tmp3Q6zDrTI6UOqnwepvAhEXUvUjVQzDS2i382Y7pfjJMWlQrTOuyvog76zCzwGbouUsLCM6UabBn0dd8m2mC+SOReVCFscNyvxX+BnNS9OvSoB5TtqEFn/9c1jjYQ5teHnC2DIGnkU83wwdpFlG26Mnr20EovG3D2webeU9HJF91zjVacrd2tPEtO47X/H3ZB8YKl+Kew==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Tue, 28 Apr 2026 12:46:05 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHc1ueIRqVwa6XF+EmdwmZHnLQLGLX0a0xH
- Thread-topic: [PATCH 1/2] Remove ASSERT on CacheGet object allocation failure
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>
________________________________________
From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 28 April 2026 9:17 AM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Tu Dinh; Owen Smith
Subject: [PATCH 1/2] Remove ASSERT on CacheGet object allocation failure
When the grant table is exhausted, CacheGetObjectFromSlab can fail and
return NULL. Failing with an assert here prevents the grant exhaustion
from being handled elsewhere.
Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
src/xenbus/cache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
index e61033d..e58e2f9 100644
--- a/src/xenbus/cache.c
+++ b/src/xenbus/cache.c
@@ -623,7 +623,6 @@ again:
Slab = CONTAINING_RECORD(ListEntry, XENBUS_CACHE_SLAB, ListEntry);
Object = CacheGetObjectFromSlab(Slab);
- ASSERT(Object != NULL);
//
// If the slab is now fully occupied, ove the cursor on to the next
--
2.53.0.windows.2
--
| Vates
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
