Re: [PATCH 6/7] Remove Error logging from RangeSetPop

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 11/11/2025 09:34, Owen Smith wrote:
> Reduce logging to Trace, so its only displayed in checked builds.
> Failures reported here would result in the range set being expanded, and
> failures in expanding the range set will report errors.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xenbus/range_set.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/xenbus/range_set.c b/src/xenbus/range_set.c
> index 76d04c4..ceed3b9 100644
> --- a/src/xenbus/range_set.c
> +++ b/src/xenbus/range_set.c
> @@ -237,15 +237,15 @@ found:
>       return STATUS_SUCCESS;
>   
>   fail3:
> -    Error("fail3\n");
> +    Trace("fail3\n");
>   
>   fail2:
> -    Error("fail2\n");
> +    Trace("fail2\n");
>   
>       KeReleaseSpinLock(&RangeSet->Lock, Irql);
>   
>   fail1:
> -    Error("fail1 (%08x)\n", status);
> +    Trace("fail1 (%08x)\n", status);
>   
>       return status;
>   }



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech