[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [win-pv-devel] [PATCH 3/4] Ignore missing requests for responses


  • To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Tue, 17 Sep 2019 15:08:40 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@xxxxxxxxxx; spf=Pass smtp.mailfrom=owen.smith@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Delivery-date: Tue, 17 Sep 2019 15:08:46 +0000
  • Ironport-sdr: Dj7/HayuiXXb6zeyZ0d/hEhjb8U4TJo9nP3vmxYk837f64GXFeS8egFhaE8U3twlE4C9EN4wSb zxwuJCYoVQgb7112smZ4NzZWEqvdzD52krgZhLFAhKWz3yd3F2pbXIeRJ98D+ukpe/tkZl3wzI xexdjY27Uj14rVEGMppGy+IcNABvJCMd2uT2VbW2fSnf0hn7zlTPx8Q+RnZOwqx5dGuAIGYQpM 8utRRZpKfI1FKhu1oeWAyykMAZ0K8d78NtpWe8/29LjnF/TemCi89mvubsSc+x8NPPK1Ygx/9t lL0=
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Thread-index: AQHVbKJ1TKuYUexvQUSTZBg13CyNeKcv1YcAgAAj++A=
  • Thread-topic: [win-pv-devel] [PATCH 3/4] Ignore missing requests for responses


> -----Original Message-----
> From: Paul Durrant
> Sent: 17 September 2019 15:57
> To: Owen Smith <owen.smith@xxxxxxxxxx>; win-pv-
> devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: RE: [win-pv-devel] [PATCH 3/4] Ignore missing requests for
> responses
> 
> > -----Original Message-----
> > From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On
> > Behalf Of Owen Smith
> > Sent: 16 September 2019 16:18
> > To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> > Subject: [win-pv-devel] [PATCH 3/4] Ignore missing requests for
> > responses
> >
> > Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> > ---
> >  src/xenvbd/ring.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/xenvbd/ring.c b/src/xenvbd/ring.c index
> > 3be7c14..d5db1da 100644
> > --- a/src/xenvbd/ring.c
> > +++ b/src/xenvbd/ring.c
> > @@ -1248,11 +1248,10 @@ BlkifRingPoll(
> >
> >              Request = __BlkifRingGetSubmittedRequest(BlkifRing,
> >                                                       rsp->id);
> > -            ASSERT3P(Request, != , NULL);
> > -
> > -            __BlkifRingCompleteResponse(BlkifRing,
> > -                                        Request,
> > -                                        rsp->status);
> > +            if (Request != NULL)
> > +                __BlkifRingCompleteResponse(BlkifRing,
> > +                                            Request,
> > +                                            rsp->status);
> 
> Could you elaborate on when this would happen? If there is a valid response
> on the ring, why would there not be a corresponding request?
> 
>   Paul

This can happen if the requests stored on the SubmittedList are failed before 
responses are received, like when the backend is recreated after a suspend. 
This will only happen with the next patch - I'll combine this and the next for 
v2.

Owen

> 
> >
> >              if (rsp_cons - BlkifRing->Front.rsp_cons > 
> > XENVBD_BATCH(BlkifRing))
> >                  Retry = TRUE;
> > --
> > 2.16.2.windows.1
> >
> >
> > _______________________________________________
> > win-pv-devel mailing list
> > win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.