[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [win-pv-devel] [PATCH 3/4] Ignore missing requests for responses


  • To: Owen Smith <owen.smith@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
  • Date: Tue, 17 Sep 2019 14:57:02 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=Paul.Durrant@xxxxxxxxxx; spf=Pass smtp.mailfrom=Paul.Durrant@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Owen Smith <owen.smith@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Sep 2019 14:57:08 +0000
  • Ironport-sdr: bnydkAJ1c0n/OtHq14CTDBIdNH0TvZA/RJdelST/BvjkzQa8IwiVwEt4f9iHAYC3iwaZ2RRX7S t+XzrfRp8FCylhoV4SzWqBFy6UsGco8dGNaS3wptWDxTBlDUGpS15qRMtDosk7vIA4OYwCr3/g HyqdI4nrBMyyG/M523pz3XF+4hHqJqvYAnNrzHRKvn/dclS1sbyhfId5URYXsc0HScE1pe9VRj T4Rvf0hTIK0t/qnAxoi35w+T9/uJymg1jPXP+xJq+gwgvleKVj1BuvLD0zkuZqI8aH7bSLbr/h nFQ=
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Thread-index: AQHVbKKEPR/TpwXq4U2eWrR5R6Xn66cv9lDg
  • Thread-topic: [win-pv-devel] [PATCH 3/4] Ignore missing requests for responses

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 16 September 2019 16:18
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 3/4] Ignore missing requests for responses
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>  src/xenvbd/ring.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/src/xenvbd/ring.c b/src/xenvbd/ring.c
> index 3be7c14..d5db1da 100644
> --- a/src/xenvbd/ring.c
> +++ b/src/xenvbd/ring.c
> @@ -1248,11 +1248,10 @@ BlkifRingPoll(
> 
>              Request = __BlkifRingGetSubmittedRequest(BlkifRing,
>                                                       rsp->id);
> -            ASSERT3P(Request, != , NULL);
> -
> -            __BlkifRingCompleteResponse(BlkifRing,
> -                                        Request,
> -                                        rsp->status);
> +            if (Request != NULL)
> +                __BlkifRingCompleteResponse(BlkifRing,
> +                                            Request,
> +                                            rsp->status);

Could you elaborate on when this would happen? If there is a valid response on 
the ring, why would there not be a corresponding request?

  Paul

> 
>              if (rsp_cons - BlkifRing->Front.rsp_cons > 
> XENVBD_BATCH(BlkifRing))
>                  Retry = TRUE;
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.