[win-pv-devel] [PATCH xenbus] Fix control/shutdown acknowledgement

[Paul Durrant <paul.durrant@xxxxxxxxxx>]

The code in FdoSuspend() currently acknowledges a suspend request by
removing the control/shutdown node from xenstore. This is not correct.

The documentation [1] states that a request should be acknowledged by
writing the empty string. This patch makes the code behave correctly.

[1] 
xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/xenstore-paths.markdown;hb=HEAD#l413

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenbus/fdo.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c
index 7f67b61..8ca8f52 100644
--- a/src/xenbus/fdo.c
+++ b/src/xenbus/fdo.c
@@ -1524,11 +1524,12 @@ FdoSuspend(
         if (!NT_SUCCESS(status))
             goto loop;
 
-        (VOID) XENBUS_STORE(Remove,
+        (VOID) XENBUS_STORE(Printf,
                             &Fdo->StoreInterface,
                             NULL,
                             "control",
-                            "shutdown");
+                            "shutdown",
+                            "");
 
         (VOID) XENBUS_SUSPEND(Trigger, &Fdo->SuspendInterface);
 
-- 
2.5.3


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel