[win-pv-devel] [PATCH xeniface 1/2] Revert "Ack "control/shutdown" as soon as possible."

[Paul Durrant <paul.durrant@xxxxxxxxxx>]

This reverts commit c370c7d2. This patch has the effect of 'acking' any
write to control/shutdown rather than just the ones that the agent acts
upon. Consequentially it therefore 'acks' its own writes and ends up in
an infinite loop.
---
 src/xenagent/service.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/xenagent/service.cpp b/src/xenagent/service.cpp
index 96e620a..46250e8 100644
--- a/src/xenagent/service.cpp
+++ b/src/xenagent/service.cpp
@@ -187,13 +187,12 @@ bool CXenIfaceCreator::CheckShutdown()
     if (!m_device->StoreRead("control/shutdown", type))
         return false;
 
-    m_device->StoreWrite("control/shutdown", "");
-
     CXenAgent::Log("Shutdown(%ws) = %s\n", m_device->Path(), type.c_str());
 
     if (type == "poweroff") {
         m_agent.EventLog(EVENT_XENUSER_POWEROFF);
 
+        m_device->StoreWrite("control/shutdown", "");
         AcquireShutdownPrivilege();
 #pragma warning(suppress:28159) /* Consider using a design alternative... 
Rearchitect to avoid Reboot */
         if (!InitiateSystemShutdownEx(NULL, NULL, 0, TRUE, FALSE,
@@ -206,6 +205,7 @@ bool CXenIfaceCreator::CheckShutdown()
     } else if (type == "reboot") {
         m_agent.EventLog(EVENT_XENUSER_REBOOT);
 
+        m_device->StoreWrite("control/shutdown", "");
         AcquireShutdownPrivilege();
 #pragma warning(suppress:28159) /* Consider using a design alternative... 
Rearchitect to avoid Reboot */
         if (!InitiateSystemShutdownEx(NULL, NULL, 0, TRUE, TRUE,
@@ -218,6 +218,7 @@ bool CXenIfaceCreator::CheckShutdown()
     } else if (type == "s4") {
         m_agent.EventLog(EVENT_XENUSER_S4);
 
+        m_device->StoreWrite("control/shutdown", "");
         AcquireShutdownPrivilege();
         if (!SetSystemPowerState(FALSE, FALSE)) {
             CXenAgent::Log("SetSystemPowerState failed %08x\n", 
GetLastError());
@@ -226,6 +227,7 @@ bool CXenIfaceCreator::CheckShutdown()
     } else if (type == "s3") {
         m_agent.EventLog(EVENT_XENUSER_S3);
 
+        m_device->StoreWrite("control/shutdown", "");
         AcquireShutdownPrivilege();
         if (!SetSuspendState(FALSE, TRUE, FALSE)) {
             CXenAgent::Log("SetSuspendState failed %08x\n", GetLastError());
-- 
2.5.3


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel