Re: [PATCH] mini-os: netfront: Read netmask and gateway from Xenstore

[Costin Lupu <costin.lupu@xxxxxxxxx>]

On 8/18/20 7:50 PM, Samuel Thibault wrote:
> Thanks for this netmask+gateway support. However wondering:
> 
> Costin Lupu, le mar. 18 août 2020 16:45:37 +0300, a ecrit:
>> The patch also makes the 'gw' variable global in order to be used by other
>> source files when communication with the gateway is needed.
> 
> What is the use case here?
> 
> This really should be inside struct netfront_dev, and define a getter
> for it. And along the way, added ip and mask similarly.

Hi Samuel,

Thanks for your reviews.

Indeed, this change was squeezed here. I'll recreate the patch without it.

I needed to send an UDP message to the gateway and (this was some time
ago) I remember that for the other values you could query the lwip
stack, it had some functions for retrieving at least the IP. But you're
right, a solution with getters on netfront_dev would be cleaner. I'll
try to send a separate patch for that, but I don't promise. :-)

Cheers,
Costin