[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mini-os: netfront: Read netmask and gateway from Xenstore



Thanks for this netmask+gateway support. However wondering:

Costin Lupu, le mar. 18 août 2020 16:45:37 +0300, a ecrit:
> The patch also makes the 'gw' variable global in order to be used by other
> source files when communication with the gateway is needed.

What is the use case here?

This really should be inside struct netfront_dev, and define a getter
for it. And along the way, added ip and mask similarly.

Samuel



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.