[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [UNIKRAFT/GEMMLOWP PATCH] Add supress flags for cleaner builds.



Reviewed-by: George Muraru <murarugeorgec@xxxxxxxxx>

On Wed, Apr 22, 2020 at 3:29 PM George-Cristian Muraru <murarugeorgec@xxxxxxxxx> wrote:
+LIBGEMMLOWP_SUPPRESS_FLAGS += -Wno-sign-compare
+LIBGEMMLOWP_CFLAGS-y += $(LIBGEMMLOWP_SUPPRESS_FLAGS)
+LIBGEMMLOWP_CXXFLAGS-y += $(LIBGEMMLOWP_SUPPRESS_FLAGS)

Hey Felipe. Thank you for the upgrade!

Another warning sign that I had while testing was this this one:
"/main.cpp: In function ‘void gemmlowp::test_gemm_impl(typename GemmWrapper::Context*,
const LhsType&, const RhsType&, ResultType*, int, int, int, int, int, int)’:
apps/app-gemmlowp/main.cpp:434:48: warning: typedef ‘BitDepthParams’
locally defined but not used [-Wunused-local-typedefs]
Maybe we can also add the -Wunused-local-typedefs into the SUPPRESS_FLAGS?

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.