Re: [UNIKRAFT/LIBFFT2D PATCH] Set default "dimension" menu option to 2, as needed by tflite.

[George-Cristian Muraru <murarugeorgec@xxxxxxxxx>]

Hey Felipe, looks good!

There is a minor thing (I think), the "default" text seems like it should

be indented with one more space.

This can be fixed while upstreaming!

Reviewed-by: George Muraru <murarugeorgec@xxxxxxxxx>

On Thu, Apr 23, 2020 at 6:34 AM George-Cristian Muraru <murarugeorgec@xxxxxxxxx> wrote:

Hey Felipe,

It looks ok, but I do not know why in the link from patchwork[1] it looks

like "default" should be indented with one more space.

[1] https://patchwork.unikraft.org/patch/737590/

On Fri, Apr 17, 2020 at 11:29 PM Felipe Huici <felipe.huici@xxxxxxxxx> wrote:

There is no practical way to programmatically set a choice option in
kConfig, so we set the default value to 2, as needed by TensorFlow
Lite. We also add suppress flags for cleaner builds.

Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx
---
 Config.uk   |  3 ++-
 Makefile.uk | 10 ++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/Config.uk b/Config.uk
index 73f6b2e..58aeaf1 100644
--- a/Config.uk
+++ b/Config.uk
@@ -1,5 +1,5 @@
 menuconfig LIBFFT2D
-    bool "Fast Fourier Transform library"
+    bool "libff2td - Fast Fourier Transform library"
     select LIBUNWIND
     select LIBCOMPILER-RT
     select LIBCXX
@@ -11,6 +11,7 @@ menuconfig LIBFFT2D
 if LIBFFT2D
     choice DIMENSION
         prompt "DIMENSION"
+       default LIBFFT2D_2D

         config LIBFFT2D_1D
             bool "1"
diff --git a/Makefile.uk b/Makefile.uk
index 3a00071..412319f 100644
--- a/Makefile.uk
+++ b/Makefile.uk
@@ -49,9 +49,15 @@ LIBFFT2D_SRC=$(LIBFFT2D_ORIGIN)/$(LIBFFT2D_SUBDIR)
 ################################################################################
 # Library includes
 ################################################################################
-CXXINCLUDES-$(CONFIG_LIBFFT2D) += -I$(LIBFFT2D_SRC)/
+CXXINCLUDES-$(CONFIG_LIBFFT2D) += -I$(LIBFFT2D_SRC)
+CINCLUDES-$(CONFIG_LIBFFT2D) += -I$(LIBFFT2D_SRC)

-CINCLUDES-$(CONFIG_LIBFFT2D) += -I$(LIBFFT2D_SRC)/
+################################################################################
+# Global flags
+################################################################################
+LIBFFT2D_SUPPRESS_FLAGS += -Wno-unused-parameter
+LIBFFT2D_CFLAGS-y += $(LIBFFT2D_SUPPRESS_FLAGS)
+LIBFFT2D_CXXFLAGS-y += $(LIBFFT2D_SUPPRESS_FLAGS)

 ################################################################################
 # Library sources
--
2.20.1