Re: [Minios-devel] [UNIKRAFT PATCH v3 1/8] build: Test parameter A= to be an absolute path

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi Simon, this patch looks good, thanks.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Fri, Mar 27, 2020 at 4:35 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Stops building with an error message when A= (application directory)
> is not an absolute path. The build system does not support relative paths.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b1e80303..2ae8a948 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -100,16 +100,20 @@ ifeq ($(CONFIG_UK_BASE),)
>  $(error "Invalid base directory (CONFIG_UK_BASE)")
>  endif
>
> -# A // APP_DIR
> +# parameter A: APP_DIR ###
>  # Set A variable if not already done on the command line;
>  ifneq ("$(origin A)", "command line")
> -A := $(CONFIG_UK_BASE)
> +override A := $(CONFIG_UK_BASE)
> +else
> +ifeq ("$(filter /%,$(A))", "")
> +$(error Path to app directory (A) is not absolute)
> +endif
>  endif
>  # Remove the trailing '/.'
>  # Also remove the trailing '/' the user can set when on the command line.
>  override A := $(realpath $(patsubst %/,%,$(patsubst %.,%,$(A))))
>  ifeq ($(A),)
> -$(error "Invalid app directory (A)")
> +$(error Invalid app directory (A))
>  endif
>  override CONFIG_UK_APP   := $(A)
>  override APP_DIR  := $(A)
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel