Re: [Minios-devel] [UNIKRAFT PATCH] build: Move -mgeneral-regs-only to optional flag

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Looks good. Thanks for your work!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 25.03.20 15:44, Sharan Santhanam wrote:
> -mgeneral-regs flag was introduced since gcc 7.1 on x86_64. Using
> it as a mandatory flag cause compilation error on version less than
> 7. Hence moving this flag as a optional flag.
>
> Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> ---
>   arch/x86/x86_64/Makefile.uk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/x86_64/Makefile.uk b/arch/x86/x86_64/Makefile.uk
> index 3d0b34d..24919fb 100644
> --- a/arch/x86/x86_64/Makefile.uk
> +++ b/arch/x86/x86_64/Makefile.uk
> @@ -9,7 +9,8 @@ CXXINCLUDES += -I$(CONFIG_UK_BASE)/arch/x86/x86_64/include
>   
>   # compiler flags to prevent use of extended (FP, SSE, AVX) registers.
>   # This is for files that contain trap/exception/interrupt handlers
> -ISR_ARCHFLAGS += -mno-80387 -mno-fp-ret-in-387 -mno-mmx -mno-sse -mno-avx 
> -mgeneral-regs-only
> +ISR_ARCHFLAGS += -mno-80387 -mno-fp-ret-in-387 -mno-mmx -mno-sse -mno-avx
> +ISR_ARCHFLAGS-$(call gcc_version_ge,7,1) += -mgeneral-regs-only
>   
>   ARCHFLAGS-$(CONFIG_MARCH_X86_64_GENERIC)        += -mtune=generic
>   ISR_ARCHFLAGS-$(CONFIG_MARCH_X86_64_GENERIC)    += -mtune=generic
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel