Re: [Minios-devel] [UNIKRAFT/LWIP PATCH] Makefile.uk: Compile getnameinfo.c only when DNS is enabled

[Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>]

Thanks, Costin!

Reviewed-by: Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>

On 04.10.2019 19:52, Costin Lupu wrote:
> getnameinfo() function needs definitions that are enabled only when LWIP_DNS is
> configured.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   Makefile.uk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 0e72336..79a6dc6 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -86,7 +86,7 @@ LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/init.c|unikraft
>   LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/time.c|unikraft
>   LIBLWIP_SRCS-$(CONFIG_LWIP_SOCKET) += $(LIBLWIP_BASE)/sockets.c|unikraft
>   LIBLWIP_SOCKETS_FLAGS-y += -Wno-cast-function-type
> -LIBLWIP_SRCS-$(CONFIG_LWIP_SOCKET) += $(LIBLWIP_BASE)/getnameinfo.c|unikraft
> +LIBLWIP_SRCS-$(CONFIG_LWIP_DNS) += $(LIBLWIP_BASE)/getnameinfo.c|unikraft
>   LIBLWIP_SRCS-y += $(LIBLWIP_EXTRACTED)/core/init.c
>   LIBLWIP_SRCS-y += $(LIBLWIP_EXTRACTED)/core/def.c
>   LIBLWIP_SRCS-y += $(LIBLWIP_EXTRACTED)/core/inet_chksum.c
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel