[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH] lib/uknetdev: Select virtio driver on KVM when enabling library



Thanks, Costin!

Reviewed-by: Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>

On 04.10.2019 19:34, Costin Lupu wrote:
Using the uknetdev library alone does not make much sense without a network
driver. Moreover, it's cleaner to tick network support just once and all
underlying dependencies to be enabled. We reached these conclusions at several
Unikraft hackathons we did so far.

Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
---
  lib/uknetdev/Config.uk | 1 +
  1 file changed, 1 insertion(+)

diff --git a/lib/uknetdev/Config.uk b/lib/uknetdev/Config.uk
index 618e8e67..2de7aca0 100644
--- a/lib/uknetdev/Config.uk
+++ b/lib/uknetdev/Config.uk
@@ -4,6 +4,7 @@ menuconfig LIBUKNETDEV
        select LIBNOLIBC if !HAVE_LIBC
        select LIBUKDEBUG
        select LIBUKALLOC
+       select VIRTIO_NET if PLAT_KVM
if LIBUKNETDEV
        config LIBUKNETDEV_MAXNBQUEUES

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.