Re: [Minios-devel] [UNIKRAFT v2 0/8] Time functions refactoring

[Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>]

Hi Costin,

Thanks for the patches!

Roxana

On 04.10.2019 10:51, Costin Lupu wrote:
> nolibc and newlib have duplicated code for time functions, therefore it makes
> more sense to move them in common library.
>
> Changes since v1:
> - Add utime.h
> - Remove time.h headers from nolibc
> - Fix nolibc build
>
> Costin Lupu (8):
>    lib/uktime: Adapt time.h to Unikraft
>    lib/uktime: Import utime.h from musl
>    lib/uktime: Adapt utime.h to Unikraft
>    lib/uktime: Import sys/time.h from musl
>    lib/uktime: Adapt sys/time.h to Unikraft
>    lib/nolibc: Move time.c to lib/uktime
>    lib/uktime: Add the missing changes from newlib's time.c
>    lib/uktime: Fix build with nolibc
>
>   lib/nolibc/Makefile.uk                        |  1 -
>   lib/nolibc/exportsyms.uk                      | 10 ---
>   .../include/nolibc-internal/shareddefs.h      | 20 ++++++
>   lib/nolibc/include/sys/time.h                 | 61 -----------------
>   lib/nolibc/include/sys/types.h                |  3 +
>   lib/nolibc/include/time.h                     | 65 -------------------
>   lib/nolibc/include/unistd.h                   |  1 +
>   lib/uktime/Config.uk                          |  2 +-
>   lib/uktime/Makefile.uk                        |  1 +
>   lib/uktime/exportsyms.uk                      |  9 +++
>   lib/uktime/musl-imported/include/sys/time.h   | 64 ++++++++++++++++++
>   lib/uktime/musl-imported/include/time.h       | 25 +------
>   lib/uktime/musl-imported/include/utime.h      | 23 +++++++
>   lib/{nolibc => uktime}/time.c                 | 41 +++++++++++-
>   14 files changed, 161 insertions(+), 165 deletions(-)
>   delete mode 100644 lib/nolibc/include/sys/time.h
>   delete mode 100644 lib/nolibc/include/time.h
>   create mode 100644 lib/uktime/musl-imported/include/sys/time.h
>   create mode 100644 lib/uktime/musl-imported/include/utime.h
>   rename lib/{nolibc => uktime}/time.c (84%)
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel