Re: [Minios-devel] [UNIKRAFT/LIBNEWLIBC PATCH 1/1] Revisit the pipe function

[Costin Lupu <costin.lup@xxxxxxxxx>]

Thanks, Vlad!

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 9/4/19 6:47 PM, Vlad-Andrei BĂDOIU (78692) wrote:
> The pipe(...) stub should return an error. This is becuase the callee
> will try to use the file descriptors returned by this function.
> 
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> ---
>  file.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/file.c b/file.c
> index 1566679..7d78f79 100644
> --- a/file.c
> +++ b/file.c
> @@ -116,7 +116,8 @@ int utimes(const char *filename __unused,
>  
>  int pipe(int pipefd[2] __unused)
>  {
> -     return 0;
> +     errno = EFAULT;
> +     return -1;
>  }
>  
>  char *realpath(const char *restrict file_name, char *restrict resolved_name)
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel