[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Update fcntl() related definitions


  • To: Costin Lupu <costin.lupu@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
  • From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
  • Date: Wed, 4 Sep 2019 16:24:37 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/vbKjuzAnoHR5+VmH+UjKxxDeZ8oEUsnjHfonvUweNg=; b=jtW6+RYjPCyZEvTIU/kSDII7NmJVeyHJV6BYlANv6joCfrRk2lKiFes9YA+RCDkonVlyGHCfIYScyLoVPipKTRUHsg3k00X/zjUujZrjoqjSjUQfpdFUFkynN4CRfDPfl1kY56qXqjTiHAyXXjBFTOMyFJKbWmCzdzk1I9O7cUhJKsdhf279gGyPnOEXPdPsU+UbOGA7wbaIA2QyjYOJOqIPhNZ14RPTXY/avAIp+ZKKFKCr7JO8WT84Hi5nnTNefy6wSnDnlN1kDqEWs4q04uj7uRfqDOSp/+NgxI9ZagteSrN/W8RW4n4EYGFxUKCeIwBNjKUSMcxeEHT3sAW4zw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMcB/6OsbaJCiiS2xDQrOoPaPtDlqyHJFneqNme1MOg5l4dPhNmj1VMZ4xHt2XlzCElUll4VC3703WyjLh0O5mcVGv1FhWkGSjyhuV3wqX1rhZ7t2pu9L6G9spEr0C556D0kk/bxFrhxoCLklJY4ix/TM2zHKWnUs/zq2//RjqlQfS0Ew/dcvgmcG742eRwJysZihVSGrY0QrXtUJFeNkiE3urVm6xoCjkdymLF7hmg6ocmou7rPuLTVU3G8QMYAZpQWbaf/jJX237J4fwqUM8wys6jFalRx5ClDcUog+IF9SN5YJDV9u8mP1t5w3FN0QDD7cpoG6wO5M0CYHyWh8g==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
  • Delivery-date: Wed, 04 Sep 2019 16:24:41 +0000
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>
  • Thread-index: AQHVYzFhCCxSBeU0yUGeFLifO0bTQqcbtBeA
  • Thread-topic: [UNIKRAFT/NEWLIB PATCH] Update fcntl() related definitions

Reviewed-by: Vlad-Andrei Badoiu<vlad_andrei.badoiu@xxxxxxxxxxxxxxx>

On 04.09.2019 17:59, Costin Lupu wrote:
> Since we are using the fcntl() implementation in vfscore, we don't use 
> newlib's
> any more. This patch also adds some flags that are needed by fcntl() and that
> were copied from musl, just like the previous ones from fcntl.h.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   Makefile.uk     |  2 +-
>   include/fcntl.h | 13 ++++++++++---
>   2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index c02c2f0..01da724 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -792,7 +792,7 @@ LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/string/wcsdup.c
>   
> ################################################################################
>   # Newlib/libc code -- syscalls
>   
> ################################################################################
> -LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/syscalls/sysfcntl.c
> +#LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/syscalls/sysfcntl.c
>   
>   
> ################################################################################
>   # Newlib/libc code -- time
> diff --git a/include/fcntl.h b/include/fcntl.h
> index 25a4808..7a35052 100644
> --- a/include/fcntl.h
> +++ b/include/fcntl.h
> @@ -11,15 +11,22 @@
>   #define O_DIRECTORY 0200000
>   #define O_CLOEXEC  02000000
>   #define O_DSYNC      010000
> -#endif
> -
> -#if ((defined CONFIG_ARCH_ARM_64) || (defined CONFIG_ARCH_ARM_32))
> +#define O_ASYNC      020000
> +#define O_DIRECT     040000
> +#define O_NOATIME  01000000
> +#elif ((defined CONFIG_ARCH_ARM_64) || (defined CONFIG_ARCH_ARM_32))
>   #define O_NOFOLLOW  0100000
>   #define O_DIRECTORY  040000
>   #define O_CLOEXEC  02000000
>   #define O_DSYNC      010000
> +#define O_ASYNC      020000
> +#define O_DIRECT    0200000
> +#define O_NOATIME  01000000
>   #endif
>   
> +#define FIONBIO      0x5421
> +#define FIOASYNC     0x5452
> +
>   
>   /* Glibc does not provide KEEP_SIZE and PUNCH_HOLE anymore. Instead it
>    * includes linux/falloc.h.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.