Re: [Minios-devel] [UNIKRAFT PATCHv5 3/6] plat/common: Implement gic-v2 library for Arm

[Jia He <jiakernel2@xxxxxxxxx>]

[This reply is on behalf of Jianyong.wu@xxxxxxx]

hi Sharan,

sorry to have not got this email for outlook issue. pls find the reply.

On 2019/7/10 1:31, Sharan Santhanam wrote:
> Hello Jianyong Wu,
>
> Please find the comments inline.
>
> Thanks & Regards
> Sharan
>
> On 6/28/19 9:09 AM, Jia He wrote:
> > From: Jianyong Wu <jianyong.wu@xxxxxxx>
[...]
> > +}
> > +
>
>
> This function definition assume single CPU which is fine for now. Maybe, we 
> could add TODO stating we need to extend the function cpu interface.
> > +static void gic_init_cpuif(void)
> > +{
> > +    uint32_t i;
> > +    /*
> > +     * set priority mask to the lowest priority to let all irq
> > +     * visible to cpu interface
> > +     */
> > +    gic_set_threshold_priority(GICC_PMR_PRIO_MAX);
> > +
>
> Is this operation valid? From the GIC specification v2 these
>
>
> register are read only register and PPI register
>
>
> are implementation defined. Atleast the GICD_ICFGR0 is readonly.
as GICD_ICFGR0 is read only for SGIs and depending on implementation for PPIs,

I will remove these codes.

Cheers,

Jianyong wu


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel