Re: [Minios-devel] [UNIKRAFT PATCHv5 3/6] plat/common: Implement gic-v2 library for Arm

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Justin,



On 7/10/19 6:32 AM, Justin He (Arm Technology China) wrote:
> Hi Sharan
>
> > -----Original Message-----
> > From: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> > Sent: 2019年7月10日 1:31
> > To: Justin He (Arm Technology China) <Justin.He@xxxxxxx>; minios-
> > devel@xxxxxxxxxxxxxxxxxxxx; Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> > Cc: Florian Schmidt <florian.schmidt@xxxxxxxxx>; Felipe Huici
> > <felipe.huici@xxxxxxxxx>; Julien Grall <Julien.Grall@xxxxxxx>;
> > yuri.volchkov@xxxxxxxxx; Kaly Xin (Arm Technology China)
> > <Kaly.Xin@xxxxxxx>; Jianyong Wu (Arm Technology China)
> > <Jianyong.Wu@xxxxxxx>; Wei Chen (Arm Technology China)
> > <Wei.Chen@xxxxxxx>
> > Subject: Re: [UNIKRAFT PATCHv5 3/6] plat/common: Implement gic-v2 library
> > for Arm
> >
> > Hello Jianyong Wu,
> >
> > Please find the comments inline.
> >
> > Thanks & Regards
> > Sharan
> [...]
>
> > > --- a/plat/kvm/Makefile.uk
> > > +++ b/plat/kvm/Makefile.uk
> > > @@ -18,6 +18,7 @@ LIBKVMPLAT_ASINCLUDES-y        += -
> > I$(LIBKVMPLAT_BASE)/include
> > >    LIBKVMPLAT_ASINCLUDES-y        += -I$(UK_PLAT_COMMON_BASE)/include
> > >    LIBKVMPLAT_CINCLUDES-y         += -I$(LIBKVMPLAT_BASE)/include
> > >    LIBKVMPLAT_CINCLUDES-y         += -I$(UK_PLAT_COMMON_BASE)/include
> > > +LIBKVMPLAT_CINCLUDES-$(CONFIG_ARCH_ARM_64)         += -
> > I$(UK_PLAT_DRIVERS_BASE)/include
> > >    LIBKVMPLAT_ASFLAGS             += -DKVMPLAT
> > >    LIBKVMPLAT_CFLAGS              += -DKVMPLAT
> > > @@ -66,6 +67,7 @@ LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(UK_PLAT_COMMON_BASE)/arm/psci_arm64.S
> > >    LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(UK_PLAT_COMMON_BASE)/arm/time.c|common
> > >    LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(UK_PLAT_COMMON_BASE)/arm/traps.c|common
> > >    LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(UK_PLAT_DRIVERS_BASE)/ofw/fdt.c|common
> >
> > Like the fdt driver library, it might be wise to split up this driver
> > from the base kvm platform code. This is similar to what we have with
> > the virtio driver and device tree driver.
> Hi Sharan, do you want to add additional patch to make it independent?
> Like what I have done in [1]
> [1] 
> https://lists.xenproject.org/archives/html/minios-devel/2019-07/msg00046.html
> Do you want add it in the future (not this series #3) or new version ?
I don't mind pushing it to a separate patch series.

> Thanks for the clarification
>
> --
> Cheers,
> Justin (Jia He)
>
>
> > > +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(UK_PLAT_DRIVERS_BASE)/gic/gic-v2.c|common
> > >    LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(LIBKVMPLAT_BASE)/arm/entry64.S
> > >    LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(LIBKVMPLAT_BASE)/arm/exceptions.S
> > >    LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) +=
> > $(LIBKVMPLAT_BASE)/arm/pagetable64.S
> > >
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended recipient, 
> please notify the sender immediately and do not disclose the contents to any 
> other person, use it for any purpose, or store or copy the information in any 
> medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel