Re: [Minios-devel] [UNIKRAFT PATCH v3 4/8] plat/linuxu: Add linuxu (ARM) interrupts support

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Costin,


On 06/14/2018 04:12 PM, Simon Kuenzer wrote:
>   void __restorer();
> +
> +#if defined __X86_64__
>   asm("__restorer:mov $15,%rax\nsyscall");
> +#elif defined __ARM_32__
> +asm("__restorer:mov r7, #0x77\nswi 0x0");
> +#else
> +#error "Unsupported architecture"
> +#endif
The patch says it adds ARM support, but you introduce some code here 
that is x86_64-specific. Shouldn't this go into patch 1 of the series?
Cheers,
Florian

--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel