Re: [Minios-devel] [UNIKRAFT PATCH 08/17] plat/common: Add ukplat_lcpu_{enable, disable}_irq functions

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Can you add a brief comment to the commit message why we need these 
functions and how they are different to ukplat_lcpu_{save,restore}_irqf().
On 27.03.2018 14:29, Costin Lupu wrote:
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   include/uk/plat/lcpu.h | 10 ++++++++++
>   plat/xen/lcpu.c        | 10 ++++++++++
>   2 files changed, 20 insertions(+)
>
> diff --git a/include/uk/plat/lcpu.h b/include/uk/plat/lcpu.h
> index 5f5939d..de37e8b 100644
> --- a/include/uk/plat/lcpu.h
> +++ b/include/uk/plat/lcpu.h
> @@ -49,6 +49,16 @@ __u8 ukplat_lcpu_count(void);
>   #endif
>   
>   /**
> + * Enables interrupts
> + */
> +void ukplat_lcpu_enable_irq(void);
> +
> +/**
> + * Disables interrupts
> + */
> +void ukplat_lcpu_disable_irq(void);
> +
> +/**
>    * Returns current interrupt flags and disables them
>    * @return interrupt flags (Note that the format is unspecified)
>    */
> diff --git a/plat/xen/lcpu.c b/plat/xen/lcpu.c
> index 476345b..eed89fb 100644
> --- a/plat/xen/lcpu.c
> +++ b/plat/xen/lcpu.c
> @@ -44,6 +44,16 @@
>   #include <uk/plat/lcpu.h>
>   #include <uk/plat/time.h>
>   
> +void ukplat_lcpu_enable_irq(void)
> +{
> +       local_irq_enable();
> +}
> +
> +void ukplat_lcpu_disable_irq(void)
> +{
> +       local_irq_disable();
> +}
> +
>   unsigned long ukplat_lcpu_save_irqf(void)
>   {
>         unsigned long flags;
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel