[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xc_save: ignore the first suspend event channel notification
On 7/9/08 03:28, "Brendan Cully" <brendan@xxxxxxxxx> wrote: >> To do this, call (*suspend) from within the retry loop: the evtchn case can >> do what it always does (basically sleep on the evtchn device until its >> evtchn of interest appears); the compat case should change behaviour after >> its first invocation so that it sleeps 10ms (stash a static variable in the >> function or in suspendinfo for this purpose, to remember whether it was >> already invoked). > > I could certainly code this up as well (it'd need a static flag in > evtchn_suspend as well to avoid resignalling the domain, I think). But > generally without clearing the event channel before signalling the > guest, the first suspend attempt will always return early. I'm not > really clear on the scenario that results in the domain not being > suspended after *suspend has succesfully returned. Could you clarify? I don't like the forced initial consumption of a single evtchn signal. I'd like rid of that and change the retry loop to call (*suspend) instead. Add an extra boolean to the static suspend_info structure to detect first invocation of (*suspend) versus repeated invocations. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |