[Xen-devel] [PATCH] dom0_ops -EPERM not -EACCES?

[Rusty Russell <rusty@xxxxxxxxxxxxxxx>]

Hi all,

        dom0_ops return -EACCES when the interface version in wrong.  I think
that an acm failure is closer to being non-priv'ed, which returns
-EPERM.  Wouldn't want dom0 tools to report they were the wrong version
just because ACM limited some operation, surely?

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (authored)

diff -r e2d1c88d50f7 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c     Thu Nov 24 00:55:37 2005
+++ b/xen/common/dom0_ops.c     Thu Nov 24 12:31:37 2005
@@ -102,7 +102,7 @@
         return -EACCES;
 
     if ( acm_pre_dom0_op(op, &ssid) )
-        return -EACCES;
+        return -EPERM;
 
     spin_lock(&dom0_lock);
 

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel