Re: [Xen-users] Compiling from source on NetBSD fails

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-06-19 at 14:58 +1000, Andrew Stuart wrote:

> Can anyone please suggest what might be wrong?
> [...]
> gcc  -DPIC -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing 
> -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement   -O0 -g3 
> -D__XEN_TOOLS__ -MMD -MF .xs.opic.d -fno-optimize-sibling-calls  -Werror -I. 
> -I/root/xen/tools/xenstore/../../tools/ -I./include 
> -I/root/xen/tools/xenstore/../../tools/libxc/include 
> -I/root/xen/tools/xenstore/../../tools/include 
> -DXEN_LIB_STORED="\"/var/lib/xenstored\"" -fno-optimize-sibling-calls 
> -DUSE_PTHREAD  -fPIC -c -o xs.opic xs.c  -I/usr/pkg/include
> xs.c: In function 'xs_watch':
> xs.c:742:40: error: 'PTHREAD_STACK_MIN' undeclared (first use in this 
> function)

I think xs.c needs to include <limits.h> to get this definition but it
is only including <pthreads.h> right now. I suppose on Linux and FreeBSD
(which I know work) it gets included incidentally somewhere else along
the lines.

I conclude this because although
http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_attr_setstacksize.html
mentions PTHREAD_STACK_MIN it doesn't actually mention that including
<pthread.h> will define it, but links to <limits.h>
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html
which does.

So, please could you try adding a #include <limits.h> to
tools/xenstore/xs.c and report back, or even better if it works submit
it as a patch (http://wiki.xen.org/wiki/Submitting_Xen_Patches gives
some guidance on the process).

Thanks,
Ian.


> xs.c:742:40: note: each undeclared identifier is reported only once for each 
> function it appears in
> /root/xen/tools/xenstore/../../tools/Rules.mk:104: recipe for target 
> 'xs.opic' failed
> gmake[3]: *** [xs.opic] Error 1
> gmake[3]: Leaving directory '/root/xen/tools/xenstore'
> /root/xen/tools/../tools/Rules.mk:123: recipe for target 
> 'subdir-install-xenstore' failed
> gmake[2]: *** [subdir-install-xenstore] Error 2
> gmake[2]: Leaving directory '/root/xen/tools'
> /root/xen/tools/../tools/Rules.mk:118: recipe for target 'subdirs-install' 
> failed
> gmake[1]: *** [subdirs-install] Error 2
> gmake[1]: Leaving directory '/root/xen/tools'
> Makefile:100: recipe for target 'install-tools' failed
> gmake: *** [install-tools] Error 2
> -bash-4.3#
> _______________________________________________
> Xen-users mailing list
> Xen-users@xxxxxxxxxxxxx
> http://lists.xen.org/xen-users



_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxx
http://lists.xen.org/xen-users