Re: [Xen-users] build xen-4.5.0-rc1 on Debian 8 (Jessie) with systemd

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-12-02 at 11:34 +0000, Ian Campbell wrote:

> Our build system appears to be using pkg-config, so I think the
> intention is that this should work without needing libsystemd-daemon.so.

This (from m4/systemd.m4) seems odd:
        AC_DEFUN([AX_CHECK_SYSTEMD_LIBS], [
                AC_CHECK_HEADER([systemd/sd-daemon.h], [
                    AC_CHECK_LIB([systemd-daemon], [sd_listen_fds], 
[libsystemddaemon="y"])
                ])
                AS_IF([test "x$libsystemddaemon" = x], [
                    AC_MSG_ERROR([Unable to find a suitable libsystemd-daemon 
library])
                ])
        
                PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon])
        
IOW we check explicitly for libsystemd-daemon first and then ask
pkg-config about how to compile/link with it. This seems redundant to
me. I think the AC_CHECK_HEADER, AC_CHECK_LIB and the following AS_IF
+AC_MSG_ERROR can all be dropped.

Ian.


_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxx
http://lists.xen.org/xen-users