Re: [Xen-users] CONFIG_PCI_MSI and drivers/xen/events.c

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Mon, Nov 09, 2009 at 09:33:00PM +0200, Pasi Kärkkäinen wrote:
> On Mon, Nov 09, 2009 at 05:40:11PM +0100, Bartosz Lis wrote:
> > Hello,
> > 
> > I try to compile pv_ops domU kernel taken from 
> > http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=shortlog;h=xen/master
> > and I'm getting:
> > 
> > ---cut here--
> >   CC      drivers/xen/grant-table.o
> >   CC      drivers/xen/features.o
> >   CC      drivers/xen/events.o
> > /root/rpm/BUILD/kernel-
> > xenUnogrsecurity-2.6.31.5x/linux-2.6.31/drivers/xen/events.c:597: error: 
> > redefinition of 'xen_destroy_irq'
> > /root/rpm/BUILD/kernel-
> > xenUnogrsecurity-2.6.31.5x/linux-2.6.31/arch/x86/include/asm/xen/pci.h:22: 
> > note: previous definition of 'xen_destroy_irq' was here
> > /root/rpm/BUILD/kernel-
> > xenUnogrsecurity-2.6.31.5x/linux-2.6.31/drivers/xen/events.c:666: error: 
> > redefinition of 'xen_create_msi_irq'
> > /root/rpm/BUILD/kernel-
> > xenUnogrsecurity-2.6.31.5x/linux-2.6.31/arch/x86/include/asm/xen/pci.h:16: 
> > note: previous definition of 'xen_create_msi_irq' was here
> > make[4]: *** [drivers/xen/events.o] Error 1
> > make[3]: *** [drivers/xen] Error 2
> > make[2]: *** [drivers] Error 2
> > make[1]: *** [sub-make] Error 2
> > 
> > The problem occured during last few days.
> > 
> > The above error arises when:
> > XEN_DOM0_PCI - not set
> > PCI_MSI=y
> > The last is automticaly selected by AMD_IOMMU.
> > 
> > The error does not arise when XEN_DOM0_PCI=y, what is usually set when one 
> > compiles dom0 kernel. 
> > 
> > Please tell me, whether it makes sense to leave AMD_IOMMU=y when compiling 
> > domU kernel. If not, I'll simply switch that symbol off.
> > 
> > When XEN_DOM0_PCI is not set arch/x86/include/asm/xen/pci.h defines 
> > xen_create_msi_irq and xen_destroy_irq as inlines. Having PCI_MSI or 
> > AMD_IOMMU 
> > set causes drivers/xen/events.c to define these as functions with 
> > nontrivial 
> > body confilicting with the inlines. 
> > 
> 
> There's a patch here:
> http://lists.xensource.com/archives/html/xen-devel/2009-11/msg00458.html
> 

And also the latest xen/master tree should build now without any patches. 
So just do "git pull" to get the latest bits.

-- Pasi


_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users