[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-tools] Re: [PATCH] Add a size parameter to xs_read_watch



On Sun, 2005-09-18 at 14:30 -0500, Anthony Liguori wrote:
> Hi,
> 
> The attached patch adds an (optional) unsigned int * parameter to 
> xs_read_watch to make it consistent with xs_read_directory.  I've been 
> experimenting with automated binding generators for libxenstore and 
> returning a char ** with an implicit size makes things quite hairy.

Agreed the interface sucks, however your solution is even stranger.  How
about:

        char *xs_read_watch(struct xs_handle *h, char **token);

With a similar "only free the return value" rule as currently.

Thanks,
Rusty,
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-tools mailing list
Xen-tools@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-tools


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.