[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XenPPC] moving HYPERVISOR_grant_table_op may not be the best idea?
since those are arch/powerpc/platforms/xen specific stick the protos in setup.h in that directory. That file will need some tending to later, but for now I'd just put it there. -JX On Jan 23, 2007, at 11:23 AM, Jerone Young wrote: So I started to move HYPERVISOR_grant_table_op from arch/powerpc/platforms/xen/gttab.c to hcall.c. Well this looks like it may not be the best idea. The reason is that it calls a static function, gnttab_pre_unmap_grant_ref, in gttab.c that would need to be added toinclude/xen/gnttab.h, and this would be the only needed for power. Where folks can be a bit annoyed by. Don't know if it is the best idea to movethis now? What do think guys think. Having HYPERVISOR_grant_table_op in hcall.c would have all thehypercalls in one place, but would require a nice ifdef in a header thatsome have been know to take issue with. _______________________________________________ Xen-ppc-devel mailing list Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ppc-devel _______________________________________________ Xen-ppc-devel mailing list Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ppc-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |