Re: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Mon, 2007-01-08 at 15:46 -0700, Yoder Stuart-B08248 wrote:
> This is a minor bug in a debug print that most likely will never 
> be seen, as start is typically 0, but it is something I noticed.
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@xxxxxxxxxxxxx>
> 
> 
> diff -r db52c7d043bb xen/arch/powerpc/boot_of.c
> --- a/xen/arch/powerpc/boot_of.c        Tue Dec 19 09:20:58 2006 -0500
> +++ b/xen/arch/powerpc/boot_of.c        Mon Jan 08 16:43:09 2007 -0600
> @@ -419,7 +419,7 @@ static void boot_of_alloc_init(int m, ui
>              start = ALIGN_UP(start, PAGE_SIZE);
> 
>              DBG("%s: marking 0x%x - 0x%lx\n", __func__,
> -                pg << PAGE_SHIFT, start);
> +                pg << PAGE_SHIFT, start << PAGE_SHIFT);
> 
>              start >>= PAGE_SHIFT;
>              while (pg < MEM_AVAILABLE_PAGES && pg < start) {

Thanks Stuart. However, the patch I just sent out an hour ago is going
to remove this code entirely. :)

I haven't checked it in yet though: I'd appreciate it if you could test
it on systemsim, and please let me know if you have any comments as
well.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel