Re: [XenPPC] [PATCH] Fix IPI stall timeout

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Nov 28, 2006, at 5:55 PM, Amos Waterland wrote:

> When using the register dump feature of Xen, one will sometimes see a
> message about an IPI finish stall.  This is because of an int to long
> comparison bug, so fix it by doing proper nanosecond based time  
> accounting.
> As a side note, our IPI remote function call latency of completion on
> a JS21 blade is: min = 34 ticks, max = 119 ticks, mean = 2691ns.
>
> Signed-off-by: Amos Waterland <apw@xxxxxxxxxx>
>
> ---
>
>  smp.c |   39 +++++++++++++++++++++++++--------------
>  1 file changed, 25 insertions(+), 14 deletions(-)
>
> diff -r e01e08ca629b xen/arch/powerpc/smp.c
> --- a/xen/arch/powerpc/smp.c    Tue Nov 28 17:01:00 2006 -0500
> +++ b/xen/arch/powerpc/smp.c    Tue Nov 28 17:40:50 2006 -0500
> @@ -90,7 +90,8 @@ int on_selected_cpus(
>      int retry,
>      int wait)
>  {
> -    int t, retval = 0, nr_cpus = cpus_weight(selected);
> +    int retval = 0, nr_cpus = cpus_weight(selected);
> +    unsigned long start, stall = tb_to_ns(timebase_freq);
Since you are using NOW(), this should have nothing to do with timebase.
so should be
  unsigned long start, stall = SECONDS(1);



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel