Re: [XenPPC] [PATCH] fix build break in exceptions.c

[Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>]

On Fri, Sep 08, 2006 at 11:09:43AM -0400, Amos Waterland wrote:
> Building exceptions.c with CRASH_DEBUG=y produces a build break, because
> gcc complains about the unused variable.

Strange I'm not seeing it here ... infact my program_exception doens't
even have an int recover ... I must be behind ;p
 
> Signed-off-by: Amos Waterland <apw@xxxxxxxxxx>
> 
> ---
> 
>  exceptions.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -r 715014b95488 xen/arch/powerpc/exceptions.c
> --- a/xen/arch/powerpc/exceptions.c   Thu Sep 07 22:09:06 2006 -0400
> +++ b/xen/arch/powerpc/exceptions.c   Fri Sep 08 11:04:55 2006 -0400
> @@ -55,11 +55,11 @@ void do_dec(struct cpu_user_regs *regs)
>  
>  void program_exception(struct cpu_user_regs *regs, unsigned long cookie)
>  {
> -    int recover = 0;
> -
>  #ifdef CRASH_DEBUG
>      __trap_to_gdb(regs, cookie);
>  #else /* CRASH_DEBUG */
> +    int recover = 0;
> +
>      show_registers(regs);
>      printk("dar 0x%016lx, dsisr 0x%08x\n", mfdar(), mfdsisr());
>      printk("hid4 0x%016lx\n", regs->hid4);


Hmm having a variable declartion after code doesn't seem right.  What about
something like (untested):
---
 void program_exception(struct cpu_user_regs *regs, unsigned long cookie)
 {
-    int recover = 0;
+    int recover;

 #ifdef CRASH_DEBUG
     __trap_to_gdb(regs, cookie);
 #else /* CRASH_DEBUG */
+    recover = 0;
     show_registers(regs);
---

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel