Re: [XenPPC] [xenppc-unstable] [TOOLS] avoid shadow ops for POWERPC

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Sun, 2006-08-20 at 13:28 -0400, Jimi Xenidis wrote:
> Hollis, I'm sure you have a better way to do this in the TCL.
> I'll be adding some shadow ops to the hypervisor, mainly to make sure  
> everyone knows that it is disabled, but this TCL was still problematic.
> -JX
> 
> On Aug 20, 2006, at 1:12 PM, Xen patchbot-xenppc-unstable wrote:
> 
> > # HG changeset patch
> > # User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> > # Node ID a7abc95d4ce4177acd9cfbd58476d521352f9ff7
> > # Parent  6b9124f9d89d58eb81847813dc0043ba3896b919
> > [TOOLS] avoid shadow ops for POWERPC
> >
> > Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> > ---
> >  tools/python/xen/xend/XendDomainInfo.py |    9 ++++++---
> >  1 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff -r 6b9124f9d89d -r a7abc95d4ce4 tools/python/xen/xend/ 
> > XendDomainInfo.py
> > --- a/tools/python/xen/xend/XendDomainInfo.py       Sun Aug 20 13:02:16  
> > 2006 -0400
> > +++ b/tools/python/xen/xend/XendDomainInfo.py       Sun Aug 20 13:06:37  
> > 2006 -0400
> > @@ -1293,9 +1293,12 @@ class XendDomainInfo:
> >              # Make sure there's enough RAM available for the domain
> >              balloon.free(m + sm * 1024)
> >
> > -            # Set up the shadow memory
> > -            sm = xc.shadow_mem_control(self.domid, mb=sm)
> > -            self.info['shadow_memory'] = sm
> > +            if os.uname()[4] in ('ppc64'):
> > +                self.info['shadow_memory'] = 0
> > +            else:
> > +                # Set up the shadow memory
> > +                sm = xc.shadow_mem_control(self.domid, mb=sm)
> > +                self.info['shadow_memory'] = sm
> >
> >              init_reservation = self.info['memory'] * 1024
> >              if os.uname()[4] in ('ia64', 'ppc64'):

Would a workaround on the Xen side make this unnecessary? In fact it
seems the current Xen code should already work, since xend will only
call PPC's shadow_mem_control() with mb=0.

Can we back out the patch above?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel