Re: [XenPPC] [linux-ppc-2.6] [POWERPC] add HYPERVISOR_xen_version(XENVER_get_features)

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Aug 10, 2006, at 1:45 PM, Hollis Blanchard wrote:

> On Wed, 2006-08-09 at 23:02 +0000, Xen patchbot-linux-ppc-2.6 wrote:
> > -       rc = xencomm_create(arg, argsize, &desc, GFP_KERNEL);
> > +       if (!slab) {
> > +               slab = slab_is_available();
> > +       }
> > +       if (slab)
> > +               rc = xencomm_create(arg, argsize, &desc, GFP_KERNEL);
> > +       else
> > +               rc = xencomm_create_mini(xc_area, XENCOMM_MINI_AREA,
> > +                                        arg, argsize, &desc);
> Why bother? If you have to use _mini() once, why not just use it  
> all the
> time?
Because _mini() is for kernel space only, and this routine services  
user-level pointers as well, I did not think that changing _mini()  
was worth it.
Actually, instead of slab_is_available() we could have use something  
like "have started init"() but I know of no such function.
-JX



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel