[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XenPPC] small bug in exceptions.S?

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
From: Mark F Mergen <mergen@xxxxxxxxxx>
Date: Tue, 20 Jun 2006 16:01:02 -0400
Delivery-date: Tue, 20 Jun 2006 13:01:05 -0700
Importance: Normal
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
Sensitivity:

I don't have a failure case, but I noticed this while reading code at line
307 in xen/arch/ppc/ppc64/exceptions.S.  It seems to me that this code
doesn't do what the comment says is intended.

    /* clear MSR:RI/EE to set SRR0/SRR1 */
    mfmsr r0
    li r13, 0
    mtmsrd r0, 1

I believe correct code would be:

    li r0,0
    mtmsrd r0, 1

Mark Mergen


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

Follow-Ups:
- Re: [XenPPC] small bug in exceptions.S?
  - From: Hollis Blanchard

Prev by Date: Re: [XenPPC] JS21/SLOF net boot commands
Next by Date: Re: [XenPPC] small bug in exceptions.S?
Previous by thread: [XenPPC] [linux-ppc-2.6] [ppc] Add preferred console, which allows us to get rid of hard-coded console=ttyS0 bootargs in Xen.
Next by thread: Re: [XenPPC] small bug in exceptions.S?
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.