[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XenPPC] [pushed] [ppc] serial port discovery and zilog device driver
On Thu, 2006-05-25 at 15:46 -0400, jimix@xxxxxxxxxxxxxx wrote: > changeset: 10387:a1a0ff01e7c7e51ee2a1b418e463edbff19d7c55 > user: jimix@xxxxxxxxxxxxxxxxxxxxx > date: Thu May 25 15:20:20 2006 -0400 > files: xen/arch/ppc/boot_of.c xen/arch/ppc/setup.c > xen/drivers/char/Makefile xen/drivers/char/ns16550.c > xen/drivers/char/pmac_zilog.c xen/drivers/char/pmac_zilog.h > xen/include/asm-ppc/uart.h xen/include/xen/serial.h > description: > [ppc] serial port discovery and zilog device driver I'm pretty unhappy with this commit. Other than the cosmetic issues, which are certainly present, some of my immediate problems are: - the existence of 'global_serial_port' - Why can't you call e.g. ns16550_init() from boot_of_serial_ns16550()? That's the exact same principle I suggested for the "platform detection" patch. - 'global_serial_port' seems to store data that's never used, such as 'clock'. - boot_of_serial_zilog/ns16550() do lots of getprop() calls to find addr_cells and size_cells, then discard the values. Before I spend too much time hacking at it, Maria, do you have a subsequent patch you're working on right now that will clean this code up? -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-ppc-devel mailing list Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ppc-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |