Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On May 22, 2006, at 11:38 AM, Hollis Blanchard wrote:

> On Fri, 2006-05-19 at 17:28 -0400, Jimi Xenidis wrote:
> > The next to lines should be guarded by #ifdef CONFIG_XEN
> > > +#include <xen/interface/xen.h>
> > > +#include <xen/public/privcmd.h>
> Oh, by the way, the Linux rule is to never ifdef includes, so I won't.
Ok, thanks for pointing this out (tho I think this file violates just  
about everything :)).
Anyway.. then the second ifdef:
> next line should be guarded by #ifdef IOCTL_PRIVCMD_HYPERCALL
>
> > > +COMPATIBLE_IOCTL(IOCTL_PRIVCMD_HYPERCALL)
is prolly unnecessary
-JX



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel