Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Fri, 2006-05-19 at 17:28 -0400, Jimi Xenidis wrote:
> On May 19, 2006, at 4:17 PM, Hollis Blanchard wrote:
> 
> > diff -r 11e1dcb7a976 -r de3e1e3bba22 arch/powerpc/platforms/xen/ 
> > hcall.c
> [...]
> > +
> > +   switch (hypercall->arg[0]) {
> > +           case XENVER_version:
> 
> NIT: I've been meaning to ask you this, tho not documented, I've  
> always thought the "style" was to put "switch" and "case" on the same  
> column?  It seesm to be the convention for both linux and xen.
> If its ambiguous I'd like to suggest that they shall be on the same col.

Lindent formats it like that, so that's fine with me.

> > diff -r 11e1dcb7a976 -r de3e1e3bba22 fs/compat_ioctl.c
> 
> The next to lines should be guarded by #ifdef CONFIG_XEN
> > +#include <xen/interface/xen.h>
> > +#include <xen/public/privcmd.h>
> >
> 
> next line should be guarded by #ifdef IOCTL_PRIVCMD_HYPERCALL
> > +COMPATIBLE_IOCTL(IOCTL_PRIVCMD_HYPERCALL)

ifdef usage is very inconsistent in that file (have a look), but I can
add these.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel