Re: [Xen-merge] Resend: [PATCH] fix boot image generation

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> 06.01.06 12:10:07
>>>
>On Thu, Jan 05, 2006 at 06:03:50PM +0100, Jan Beulich wrote:
>> This patch
>> - moves the generated boot image (and the intermediate file) into
the
>> proper (from the perspective of native builds) subdir
>
>I think it makes more sense to leave the file we build (vmlinuz) next
to
>vmlinux since it is merely a compressed/stripped version of vmlinux.

... inconsistent with the base architectures.

>I'd prefer if for xen builds we not used arch/{i386,x86_64}/boot at
all
>but had a Makefile include which creates and installs vmlinuz.  We
could
>also skip install of the header files.

Why?

>> - allows the two files to be properly removed by 'make clean'
>> - prevents unnecessary rebuilds of the two files (namely during
'make
>> install')
>> for both 32- and 64-bits.
>
>Which of the changes prevents the rebuild?

The change of the placement of the output files. Building in a certain
subdirectory implies the output files go in that subdir, but the .*.cmd
files get created where the actual outputs go. Hence, on a rebuild, they
cannot be loaded (because they live at the tree root), and thus the make
system implies that the commands to generate them have changed (as if
they were never executed).

Jan

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge